Repository navigation
Add table element finder in private API - #912
Conversation
|
This is for #911 |
aaltat
changed the title
pekkaklarck
left a comment
pekkaklarck
left a comment
There was a problem hiding this comment.
Code changes look good to me. Always nice when the diff has more red than green. I added two nitpick comments about imports, though.
There were lot of changes to tests, apparently due to indentation changes. Didn't bother to look at them too closely now, but tests seem to pass so they ought to be good too.
|
|
||
| from SeleniumLibrary import SeleniumLibrary | ||
| from SeleniumLibrary.locators import ElementFinder | ||
| from SeleniumLibrary.locators import TableElementFinder |
There was a problem hiding this comment.
Last two lines could (and IMHO should) be combined:
from SeleniumLibrary.locators import ElementFinder, TableElementFinder
| TableElementKeywords, | ||
| WaitingKeywords) | ||
| from SeleniumLibrary.locators import ElementFinder | ||
| from SeleniumLibrary.locators import TableElementFinder |
There was a problem hiding this comment.
Could (and IMHO should) be combined with the above import:
from SeleniumLibrary.locators import ElementFinder, TableElementFinder
|
The changes in the unit test are caused because the ElementFinder is not anymore a instance of the class. Now it's inherited and comes through few properties and mocking was easier this way. |
aaltat
changed the title
|
Fixed the imports and I should really stop doing imports that way. |
No description provided.